fix(cloud-security): reconcile conflicting logGroupName guidance in fix prompt#3054
Merged
Merged
Conversation
…ix prompt Cubic follow-up on the metric-filter work: the prompt told the model two different things about the CloudWatch logGroupName — the new CLOUDWATCH METRIC FILTERS section said "use the REAL log group from the read step, never a placeholder", while the older NO-PLACEHOLDERS section said to use a made-up "CloudTrail/DefaultLogGroup" default. That inconsistency could produce varying PutMetricFilter plans. Nothing in code resolves the literal "CloudTrail/DefaultLogGroup" string (real values are filled by the refine pass from read-step output), so the real log group is what's needed. Align the older guidance to "discover the trail's CloudWatch Logs log group in a read step and use that exact name — do not invent one", matching the metric-filter section. Prompt-only change; typecheck clean. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
2 Skipped Deployments
|
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Contributor
|
🎉 This PR is included in version 3.73.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Cubic follow-up to the metric-filter work (#3050). The fix-plan prompt gave the model two conflicting instructions for the CloudWatch
logGroupName:That inconsistency can produce varying
PutMetricFilterplans.Why "use the real name" is correct
Nothing in code resolves the literal
"CloudTrail/DefaultLogGroup"string (grepconfirms it's prompt-only); real values are filled by the refine pass from read-step output. A metric filter must attach to the actual log group, so a made-up name is wrong.Fix
Align the older guidance with the metric-filter section: "discover the trail's CloudWatch Logs log group in a read step (e.g. from the trail's CloudWatchLogsLogGroupArn) and use that exact, real log group name in fixSteps — do not invent a name."
Prompt-only, one-line change. Typecheck clean.
🤖 Generated with Claude Code
Summary by cubic
Align the CloudWatch
logGroupNameguidance in the remediation prompt to always use the real log group from a read step. Removes the old "CloudTrail/DefaultLogGroup" placeholder to prevent inconsistentPutMetricFilterplans.Written for commit e7af1ec. Summary will update on new commits.