Feature agent compose sidecar #46
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Parse incoming commands to detect stacker command types - Execute health checks via Docker integration with container metrics - Execute logs commands with pagination and redaction - Execute restart commands with force option support - Fall back to shell execution for unknown commands - Report all results back to Stacker API endpoint
…nested item object, handle null item, properly handles no command message, map field names - Maps Stacker s type → name and parameters → params. Extract app_code - Pulls app_code from the parameters if present
Problem:
- Agent was POSTing to /api/v1/agent/commands/{command_id}/report (404)
- Stacker expects /api/v1/agent/commands/report (no path parameter)
- Request body was missing required fields: command_id, deployment_hash, completed_at
Root Cause:
- Line 245 in http_polling.rs incorrectly constructed URL with command_id
- Function signature didn't accept deployment_hash and completed_at parameters
- Stacker's report handler requires these fields per CommandReportRequest struct
Solution:
1. Remove command_id from URL path (line 247)
2. Add command_id, deployment_hash, completed_at to request body
3. Update report_result() signature to accept all required parameters
4. Update execute_and_report() to pass deployment_hash from polling_loop
5. Fix test to match new function signature
This resolves the 404 error. The previous 403 was fixed by Casbin migration.
Related:
- stacker/migrations/20260114160000_casbin_agent_role_fix.up.sql
Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
….rs.Removed needless borrows in daemon.rs.Added #[allow(clippy::too_many_arguments)] to report_result in http_polling.rs
…th/restart so Stacker’s validator accepts them
…g docker/test-only imports
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.