Skip to content

Added: Unit field to MetricConf for OTEL metric unit support (e.g. "ms", "By", "1") #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gmbyapa merged 1 commit into from
Mar 15, 2026
Merged

Added: Unit field to MetricConf for OTEL metric unit support (e.g. "ms", "By", "1") #9

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions otel.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,6 +99,7 @@ func (r *otelReporter) Counter(conf MetricConf) Counter {
name := r.metricName(conf.Path)
counter, err := r.meter.Float64Counter(name,
metric.WithDescription(conf.Help),
metric.WithUnit(conf.Unit),
)
if err != nil {
panic(err)
Expand All @@ -124,6 +125,7 @@ func (r *otelReporter) Gauge(conf MetricConf) Gauge {

gauge, err := r.meter.Float64Gauge(name,
metric.WithDescription(conf.Help),
metric.WithUnit(conf.Unit),
)
if err != nil {
panic(err)
Expand All @@ -148,6 +150,7 @@ func (r *otelReporter) GaugeFunc(conf MetricConf, f func() float64) GaugeFunc {

_, err := r.meter.Float64ObservableGauge(name,
metric.WithDescription(conf.Help),
metric.WithUnit(conf.Unit),
metric.WithFloat64Callback(func(ctx context.Context, obs metric.Float64Observer) error {
obs.Observe(f(), metric.WithAttributes(constAttrs...))
return nil
Expand All @@ -173,6 +176,7 @@ func (r *otelReporter) Observer(conf MetricConf) Observer {
name := r.metricName(conf.Path)
histogram, err := r.meter.Float64Histogram(name,
metric.WithDescription(conf.Help),
metric.WithUnit(conf.Unit),
)
if err != nil {
panic(err)
Expand Down
3 changes: 3 additions & 0 deletions reporter.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,9 @@ type MetricConf struct {
Help string
// ConstLabels are static key-value pairs attached to every observation of this metric.
ConstLabels map[string]string
// Unit is the metric unit following UCUM conventions (e.g. "ms", "By", "1").
// Used by the OTEL backend; ignored by Prometheus.
Unit string
}

// ReporterConf configures a Reporter instance.
Expand Down
Loading