You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Will look at this PR this weekend. Thank you! This is a band-aid solution as far as I'm concerned. I'd like to rewrite the ROM loading system to:
Continue to use load-by-CRC rather than filenames. Why? Because I still use ancient ROMs that are just fine except that they don't conform to the latest MAME naming convention, whatever that may be today. I suspect many are actually in this situation and have ROM sets that work fine.
Allow multiple "dependent" ROMs to be specified (we currently allow one "parent"). This might need to be an entire DAG of dependencies given how things seem to be structured in MAME now.
This is actually not that conceptually difficult but it is a lot of sweat and toil. I might try to prototype this in Python first and then port it to C++ someday. I think the initial ROM set and game should be detected from the file passed and then any dependencies should be loaded from the same directory assuming the zip file is named "game.zip".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
new optional argument
-gameis useful for selecting a specific game from a romset zip file that contains multiple versions.