Allow specifying a ratsNestColor on net or a pin with pinAttributes#289
Open
sahil-ansari01 wants to merge 1 commit intotscircuit:mainfrom
Open
Allow specifying a ratsNestColor on net or a pin with pinAttributes#289sahil-ansari01 wants to merge 1 commit intotscircuit:mainfrom
sahil-ansari01 wants to merge 1 commit intotscircuit:mainfrom
Conversation
…o that the nets appear with that color via the rats nest in the pcb-viewer #796
Anshgrover23
suggested changes
Nov 3, 2025
| outer_diameter: distance.optional(), | ||
| from_layer: z.string(), | ||
| to_layer: z.string(), | ||
| // Allow color to be specified on vias for type uniformity, though it may be ignored downstream |
Contributor
There was a problem hiding this comment.
remove unnecessary comments.
| trace_length: z.number().optional(), | ||
| rats_nest_color: z.string().optional(), | ||
| route: z.array(pcb_trace_route_point), | ||
| // Non-empty route to avoid undefined at index 0 in consumers/tests |
| }), | ||
| ), | ||
| ), | ||
| edges: z |
Contributor
There was a problem hiding this comment.
why this change, as it is only related to adding color property only.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…o that the nets appear with that color via the rats nest in the pcb-viewer #796