fix: place SVGs in component subdirectories with explicit format flags#2464
Open
blessuselessk wants to merge 1 commit intotscircuit:mainfrom
Open
fix: place SVGs in component subdirectories with explicit format flags#2464blessuselessk wants to merge 1 commit intotscircuit:mainfrom
blessuselessk wants to merge 1 commit intotscircuit:mainfrom
Conversation
…chematic-svgs When explicit image format flags (--pcb-svgs, --schematic-svgs, --svgs, --pngs, --3d, --pcb-only, --schematic-only) are used, generate images for all builds instead of only the preview build. This matches --glbs behavior and prevents SVGs from overwriting each other when building multiple components. Fixes tscircuit/tscircuit#2550
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--pcb-svgs,--schematic-svgs, or other explicit image format flags are used, SVGs are now generated for all builds (matching--glbsbehavior) instead of only the preview build--pcb-svgs --schematic-svgswould only generate SVGs for the preview component, and multi-build scenarios could result in SVGs landing at the dist root instead of component subdirectoriesFixes tscircuit/tscircuit#2550
Test plan
build --pcb-svgs --schematic-svgs places SVGs in each component subdirectory— builds two components, verifies SVGs exist indist/first/anddist/second/, and verifies no SVGs atdist/rootbuild.test.ts, 8/8 inbuild-output-flags.test.ts, 2/2 in concurrency tests)