feat: add support --download flag to downloading and localizing 3D models from JLCPCB#2471
Open
techmannih wants to merge 2 commits intotscircuit:mainfrom
Open
feat: add support --download flag to downloading and localizing 3D models from JLCPCB#2471techmannih wants to merge 2 commits intotscircuit:mainfrom
techmannih wants to merge 2 commits intotscircuit:mainfrom
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
| const remoteUrl = remoteUrlMatch[1] | ||
|
|
||
| try { | ||
| const response = await fetch(remoteUrl) |
Contributor
There was a problem hiding this comment.
ig you should be using platformFetch instead of fetch
seveibar
reviewed
Mar 19, 2026
| return process.exit(1) | ||
| } | ||
| } else { | ||
| const partId = `C${choice.part}` |
Contributor
There was a problem hiding this comment.
Unclear naming here, rename part and partId
partNumber is fine. lcscId is better than partId and used elsewhere
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the ability to download and localize 3D models (OBJ files) when importing components from JLCPCB using the
tsci importcommand.Summary of Changes
--downloadflag to thetsci importcommand..objfiles directly from JLCPCB's CDN.content-dispositionheader to ensure the downloaded file uses the correct original filename from JLCPCB.