Fix website crash in MaintainersList by adding missing maintainer5 role config (regression from #321)#322
Merged
MustafaMulla29 merged 1 commit intotscircuit:mainfrom Mar 20, 2026
Conversation
…le config (regression from tscircuit#321)
|
@rushabhcodes is attempting to deploy a commit to the tscircuit Team on Vercel. A member of the Team first needs to authorize it. |
There was a problem hiding this comment.
Pull request overview
Fixes a production crash in the MaintainersList UI caused by a mismatch between the MAINTAINERS role values and the role configuration used for sorting/rendering.
Changes:
- Add missing
maintainer5entry toMAINTAINER_ROLES. - Reassign role
priorityvalues to keep a consistent ordering with the new role.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
MustafaMulla29
approved these changes
Mar 19, 2026
Contributor
|
Why's deployment failing |
Contributor
Author
|
@MustafaMulla29 Authorization required to deploy. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a production-breaking regression introduced in #321, where the website crashed while rendering maintainers.
Root cause
MAINTAINERS included maintainer5, but MAINTAINER_ROLES did not define maintainer5, causing:
TypeError: Cannot read properties of undefined (reading 'priority') during sort/render.
Impact
Restores website stability for the maintainers section.
Prevents this specific regression pattern from breaking the UI again.