test: add capacitive touch slider snapshot test with polygon smtpads#2036
Open
CharlesWong wants to merge 2 commits intotscircuit:mainfrom
Open
test: add capacitive touch slider snapshot test with polygon smtpads#2036CharlesWong wants to merge 2 commits intotscircuit:mainfrom
CharlesWong wants to merge 2 commits intotscircuit:mainfrom
Conversation
…scircuit#786) Add a snapshot test demonstrating capacitive touch slider implementation using polygon-shaped SMT pads with solder mask coverage. The test verifies: - 5-segment capacitive touch slider with diamond-shaped polygon pads - All pads have is_covered_with_solder_mask: true - No solder paste is generated for covered pads - Pads have correct polygon point count (4 for diamonds) - Pad centroids are distinct across the slider width Relates to tscircuit/tscircuit#786
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This was referenced Mar 11, 2026
Closed
|
This PR has been automatically marked as stale because it has had no recent activity. It will be closed if no further activity occurs. |
…ider test Remove `key` prop from <smtpad> element since SmtPadProps (a discriminated union type) does not include `key` in its type definition, causing TS2322. Also apply biome formatting to break long function call arguments across multiple lines. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
This PR has been automatically marked as stale because it has had no recent activity. It will be closed if no further activity occurs. |
Author
|
Gentle ping — this PR is still relevant and the snapshot tests are passing. Happy to rebase or address any feedback if needed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a PCB snapshot test for a 5-segment capacitive touch slider using polygon SMT pads with solder mask coverage, demonstrating the use case from tscircuit/tscircuit#786.
Test:
tests/components/normal-components/capacitive-touch-slider.test.tsxThe test creates a board with a chip footprint containing 5 diamond-shaped polygon smtpads arranged as a linear capacitive touch slider:
Verifications
polygonshapeis_covered_with_solder_mask: truepcb_solder_pasteelements generated (correct for touch pads)Related
/claim #786