Skip to content

feat: add fixture for components placed using calculating packing not rotated properly#2062

Open
rushabhcodes wants to merge 1 commit intotscircuit:mainfrom
rushabhcodes:fixture/model-orientation-circuit
Open

feat: add fixture for components placed using calculating packing not rotated properly#2062
rushabhcodes wants to merge 1 commit intotscircuit:mainfrom
rushabhcodes:fixture/model-orientation-circuit

Conversation

@rushabhcodes
Copy link
Contributor

@rushabhcodes rushabhcodes commented Mar 19, 2026

This pull request adds a new fixture

image image

R9 here is not rotated

Copilot AI review requested due to automatic review settings March 19, 2026 11:33
@vercel
Copy link

vercel bot commented Mar 19, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
tscircuit-core-benchmarks Ready Ready Preview, Comment Mar 19, 2026 11:33am

Request Review

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a new Bun test fixture to validate 3D model orientation in circuit rendering by snapshotting a board populated with multiple resistors.

Changes:

  • Added should orient all models correctly test that creates a board with nine 0402 resistors.
  • Captures a simple 3D snapshot for regression coverage.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@rushabhcodes rushabhcodes changed the title feat: add test for model orientation in circuit rendering feat: add fixture for components placed using calculating packing not rotated properly Mar 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants