fix: update SOT89 dimensions and snapshots for consistency#429
Open
rushabhcodes wants to merge 2 commits intotscircuit:mainfrom
Open
fix: update SOT89 dimensions and snapshots for consistency#429rushabhcodes wants to merge 2 commits intotscircuit:mainfrom
rushabhcodes wants to merge 2 commits intotscircuit:mainfrom
Conversation
techmannih
approved these changes
Nov 21, 2025
Member
techmannih
left a comment
techmannih
left a comment
There was a problem hiding this comment.
Difference snapshot file not updating 🧐
Contributor
|
is there a bug in the kicad parity test? why does it still match after we change the dimensions? |
Contributor
Author
I changed the body width, the kicad test only compares pads length and width |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adjusts the default SOT-89 footprint width parameter to improve dimensional consistency, and refreshes the affected SVG snapshot outputs used by the test suite.
Changes:
- Update
sot89_def.wdefault from4.20mmto4.00mm. - Regenerate/update SOT-89-related SVG snapshots to reflect the new default geometry.
Reviewed changes
Copilot reviewed 1 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
src/fn/sot89.ts |
Changes the default width (w) used when generating SOT-89 footprints. |
tests/kicad-parity/__snapshots__/sot89.snap.svg |
Updated parity snapshot for SOT-89 rendering. |
tests/kicad-parity/__snapshots__/sot89_5.snap.svg |
Updated parity snapshot for 5-pin SOT-89 rendering. |
tests/__snapshots__/sot89_5.snap.svg |
Updated unit-test snapshot for 5-pin SOT-89 rendering. |
tests/__snapshots__/sot89_3.snap.svg |
Updated unit-test snapshot for 3-pin SOT-89 rendering. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request makes a small change to the default width value in the
sot89_defschema definition, updating it from "4.20mm" to "4.00mm".