fix: correct QFN/MLP pad positioning to match IPC-7351B#531
Open
blessuselessk wants to merge 1 commit intotscircuit:mainfrom
Open
fix: correct QFN/MLP pad positioning to match IPC-7351B#531blessuselessk wants to merge 1 commit intotscircuit:mainfrom
blessuselessk wants to merge 1 commit intotscircuit:mainfrom
Conversation
QFN pads were positioned ~0.5mm too far inside the body due to a hardcoded 0.1 offset and incorrect pcdfe calculation for legsoutside=false packages. Now QFN/MLP pads center at the body edge (matching IPC-7351B), while QFP/TQFP/LQFP behavior is unchanged. Also fixes falsy-check (!param) to strict undefined check in qfn.ts to allow explicit zero values. Closes tscircuit#413
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes QFN and MLP pad positioning — pads were ~0.5mm too far inside the body due to:
0.1offset ingetQuadCoordsapplied to all packages equallypcdfecalculation forlegsoutside=false— used-pl/2(fully inside body) instead of0(at body edge)Before (QFN-32 5x5mm)
After
Changes
quad.ts: Split offset intopcdfe(pad center distance) andedgeOffset(legacy QFP nudge). QFN/MLP getpcdfe=0, edgeOffset=0. QFP/TQFP/LQFP behavior unchanged.qfn.ts: Changed!paramto=== undefinedto allow explicit zero values forpl/pw.Test plan