feat: add courtyard to SOT-223-5 footprint#537
Open
victorjzq wants to merge 1 commit intotscircuit:mainfrom
Open
feat: add courtyard to SOT-223-5 footprint#537victorjzq wants to merge 1 commit intotscircuit:mainfrom
victorjzq wants to merge 1 commit intotscircuit:mainfrom
Conversation
Add PcbCourtyardRect to the sot223_5 function to match the pattern established by other SOT footprints (sot363, sot563, sot886, etc.). The courtyard is calculated from the pad extents plus 0.25mm padding. Closes tscircuit#181
Contributor
Author
|
Hey @seveibar — this fixes the missing courtyard on SOT-223-5. CI is green, ready for review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PcbCourtyardRectto thesot223_5function insrc/fn/sot223.tssot223_5to include the courtyard overlayBUN_UPDATE_SNAPSHOTS=trueTest plan
bun test tests/sot223.test.ts— all 5 tests passbun test tests/kicad-parity/sot223_5_kicad_parity.test.ts— passes after snapshot updatefp.string("sot223_5").circuitJson()returns apcb_courtyard_rectelementfp.string("SOT-223-5").circuitJson()alias produces identical output/claim #181