feat: implement tripad footprint configuration#538
Open
victorjzq wants to merge 3 commits intotscircuit:mainfrom
Open
feat: implement tripad footprint configuration#538victorjzq wants to merge 3 commits intotscircuit:mainfrom
victorjzq wants to merge 3 commits intotscircuit:mainfrom
Conversation
Adds a tripad footprint for 3-pad SMD packages (e.g. TO-252/D-PAK style). Features two small signal pads on the left side and a larger thermal/tab pad on the right. Configurable via w, h, p, pw, ph, lw, lh parameters. Closes tscircuit#7
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
tests/tripad.test.ts
Outdated
Comment on lines
+1
to
+65
| import { test, expect } from "bun:test" | ||
| import { convertCircuitJsonToPcbSvg } from "circuit-to-svg" | ||
| import { fp } from "../src/footprinter" | ||
| import { tripad } from "../src/fn/tripad" | ||
|
|
||
| test("tripad default", () => { | ||
| const circuitJson = fp.string("tripad").circuitJson() | ||
| const pads = circuitJson.filter((e) => e.type === "pcb_smtpad") | ||
| expect(pads.length).toBe(3) | ||
| const svgContent = convertCircuitJsonToPcbSvg(circuitJson) | ||
| expect(svgContent).toMatchSvgSnapshot(import.meta.path, "tripad_default") | ||
| }) | ||
|
|
||
| test("tripad custom dimensions", () => { | ||
| const circuitJson = fp.string("tripad_w5_h4.5_p2.54").circuitJson() | ||
| const pads = circuitJson.filter((e) => e.type === "pcb_smtpad") | ||
| expect(pads.length).toBe(3) | ||
| const svgContent = convertCircuitJsonToPcbSvg(circuitJson) | ||
| expect(svgContent).toMatchSvgSnapshot( | ||
| import.meta.path, | ||
| "tripad_custom_dimensions", | ||
| ) | ||
| }) | ||
|
|
||
| test("tripad pin numbering", () => { | ||
| const result = tripad({ fn: "tripad" }) | ||
| const pads = result.circuitJson.filter((e) => e.type === "pcb_smtpad") | ||
| expect(pads.length).toBe(3) | ||
|
|
||
| // Pin 1 is top-left small pad (highest y) | ||
| const pin1 = pads.find( | ||
| (e) => e.type === "pcb_smtpad" && e.port_hints?.includes("1"), | ||
| ) | ||
| const pin2 = pads.find( | ||
| (e) => e.type === "pcb_smtpad" && e.port_hints?.includes("2"), | ||
| ) | ||
| const pin3 = pads.find( | ||
| (e) => e.type === "pcb_smtpad" && e.port_hints?.includes("3"), | ||
| ) | ||
|
|
||
| expect(pin1).toBeDefined() | ||
| expect(pin2).toBeDefined() | ||
| expect(pin3).toBeDefined() | ||
|
|
||
| // Pin 1 and 3 are on the left (negative x), pin 2 is on the right (positive x) | ||
| if (pin1 && pin2 && pin3) { | ||
| expect((pin1 as any).x).toBeLessThan((pin2 as any).x) | ||
| expect((pin3 as any).x).toBeLessThan((pin2 as any).x) | ||
| // Pin 1 is above pin 3 | ||
| expect((pin1 as any).y).toBeGreaterThan((pin3 as any).y) | ||
| // Pin 2 (large pad) is centered vertically | ||
| expect((pin2 as any).y).toBe(0) | ||
| // Large pad is bigger than small pads | ||
| expect((pin2 as any).width).toBeGreaterThan((pin1 as any).width) | ||
| expect((pin2 as any).height).toBeGreaterThan((pin1 as any).height) | ||
| } | ||
| }) | ||
|
|
||
| test("tripad direct call with custom params", () => { | ||
| const result = tripad({ fn: "tripad", w: "6mm", h: "5mm", p: "3mm" }) | ||
| const pads = result.circuitJson.filter((e) => e.type === "pcb_smtpad") | ||
| expect(pads.length).toBe(3) | ||
| const svgContent = convertCircuitJsonToPcbSvg(result.circuitJson) | ||
| expect(svgContent).toMatchSvgSnapshot(import.meta.path, "tripad_custom_call") | ||
| }) |
Contributor
There was a problem hiding this comment.
This test file violates the rule that a *.test.ts file may have AT MOST one test(...) call. The file contains 4 test cases: 'tripad default', 'tripad custom dimensions', 'tripad pin numbering', and 'tripad direct call with custom params'. According to the rule, after the first test, the user should split into multiple numbered files like tripad1.test.ts, tripad2.test.ts, etc. To fix this, create separate test files: tripad1.test.ts (for 'tripad default'), tripad2.test.ts (for 'tripad custom dimensions'), tripad3.test.ts (for 'tripad pin numbering'), and tripad4.test.ts (for 'tripad direct call with custom params').
Spotted by Graphite (based on custom rule: Custom rule)
Is this helpful? React 👍 or 👎 to let us know.
Contributor
Author
|
Hey @seveibar — tripad implementation with CI green. Ready for review! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
tripadfootprint for 3-pad SMD packages (similar to TO-252/D-PAK style)w(width),h(height),p(pitch between small pads),pw/ph(small pad width/height),lw/lh(large pad width/height)fp.string("tripad"),fp.string("tripad_w5_h4.5_p2.54")Default dimensions
Based on common tripad footprints found in the wild:
Test plan
tripad default— generates 3 pads, matches SVG snapshottripad custom dimensions— string params work correctlytripad pin numbering— pin 1/3 on left (negative X), pin 2 on right, pin 1 above pin 3, large pad bigger than small padstripad direct call with custom params— direct function call works/claim #7