feat: add silkscreen reference designator to m2host footprint#541
Open
victorjzq wants to merge 1 commit intotscircuit:mainfrom
Open
feat: add silkscreen reference designator to m2host footprint#541victorjzq wants to merge 1 commit intotscircuit:mainfrom
victorjzq wants to merge 1 commit intotscircuit:mainfrom
Conversation
…uit#34) Uncomment and properly position the silkscreenRef text in m2host.ts so that every footprint includes a reference designator silkscreen text element.
Contributor
Author
|
Hey @seveibar — adds silkscreen reference designator to m2host footprint. CI green! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
/claim #34
Enables the silkscreen reference designator text (
{REF}) on them2hostfootprint.What changed
src/fn/m2host.ts: Uncommented thesilkscreenRefTextvariable and added it to the circuit JSON outputtranslate()helper insidem2hostto also translateanchor_positionso the ref text is correctly centered with the rest of the footprinttests/__snapshots__/m2host.snap.svg: Updated snapshot to reflect the new ref textTest plan
bun test tests/m2host.test.tspasses with updated snapshot