fix: use KiCad-standard pad sizes for radial footprint#543
Open
victorjzq wants to merge 1 commit intotscircuit:mainfrom
Open
fix: use KiCad-standard pad sizes for radial footprint#543victorjzq wants to merge 1 commit intotscircuit:mainfrom
victorjzq wants to merge 1 commit intotscircuit:mainfrom
Conversation
Replace the incorrect pitch-based pad scaling (p * 0.5) with proper KiCad-standard hole sizes: polarized/electrolytic radial caps use id=1.0mm/od=2.0mm matching CP_Radial KiCad footprints, while non-polarized caps keep the existing id=0.8mm/od=1.6mm defaults.
Contributor
Author
|
Hey @seveibar — uses KiCad-standard pad sizes for radial footprint. CI green! |
Contributor
Author
|
Hey @MustafaMulla29 @rushabhcodes — this PR is CI-green and ready for review. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
/claim #188
Fixes #188
Summary
radialfootprint was using incorrect pitch-based scaling (p * 0.5) for hole pad sizes when pitch != 5mm, producing oversized pads (e.g.od=3.75forp=7.5mminstead of the correctod=2.0)id=1.0mm,od=2.0mm— matches KiCadCP_Radial_D10.0mm_P7.50mmid=0.8mm,od=1.6mm— matches KiCadC_Radial_D10.0mm_H12.5mm_P5.00mmid/odparameters continue to work as before (no override when user specifies values)Test plan
tests/radial_pad_size.test.tsverifying polarized radial at p=7.5mm producesod=2, id=1matching KiCad referenceradial_p8mmsnapshot (old code incorrectly scaled pads for non-default pitches)