Improve decoupling cap main-pin layout#101
Open
Iineman2 wants to merge 2 commits into
Open
Conversation
971079e to
4636c9a
Compare
|
@Iineman2 is attempting to deploy a commit to the tscircuit Team on Vercel. A member of the Team first needs to authorize it. |
|
Nice work on the CI fix and the deterministic layout, @Iineman2! I had a similar approach in #92, but yours is cleaner with the dependency pin. I've closed my layout PR to keep things tidy for the maintainers. Once yours is merged, I'll rebase my Trace Alignment logic (#98) on top of it so they work together. |
Author
|
Added an extra quality pass on the decoupling-cap layout work:
Local verification:
CI after the latest push: |
3ef7a23 to
b76fde2
Compare
b76fde2 to
66683c6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
decoupling_capspartitions instead of sending tiny bypass-cap groups through the generic packercircuit-to-svgto a version that exports the schematic simulation helper required by the existing test suite, making CI runnable again/claim #15
Verification
npm exec --yes bun -- test tests/PackInnerPartitionsSolver/decoupling-cap-main-pin-layout.test.tsnpm exec --yes bun -- testnpm exec --yes bun -- x tsc --noEmitnpm exec --yes bun -- run buildnpm exec --yes bun -- x biome format package.json lib/solvers/PackInnerPartitionsSolver/SingleInnerPartitionPackingSolver.ts tests/PackInnerPartitionsSolver/decoupling-cap-main-pin-layout.test.tsgit diff --check