[Fix] Improve decoupling capacitor layout with visual regression tests#105
Open
adminlip wants to merge 2 commits into
Open
[Fix] Improve decoupling capacitor layout with visual regression tests#105adminlip wants to merge 2 commits into
adminlip wants to merge 2 commits into
Conversation
…ion snapshots Add comprehensive LayoutPipelineSolver06 tests that verify the decoupling caps packing pipeline end-to-end: - Validates caps arranged in linear rows with no overlaps - Verifies sorted linear ordering per net group with uniform spacing - Includes visualization snapshot for visual regression testing Refs: tscircuit#15
|
@adminlip is attempting to deploy a commit to the tscircuit Team on Vercel. A member of the Team first needs to authorize it. |
…ibility The previous snapshot only tracked element counts (rects, lines, etc). Now the snapshot includes all 11 cap placements with (x, y, rot) and the U3 main-chip anchor position so reviewers can visually verify the linear-row arrangement and spot regressions.
adminlip
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds comprehensive pipeline-level tests for the decoupling caps specialized layout, addressing the reviewer's request for "tests with visualization snapshots."
Changes
tests/LayoutPipelineSolver/layout-pipeline-solver06.test.ts: Three end-to-end tests using the LayoutPipelineSolver06 problem (57-pin U3 chip with 13 decoupling capacitors across 2 net groups):Snapshot Content
The visual snapshot now tracks:
{ id, x, y, rot }for all 11 decoupling caps{ x: 0.79, y: 0, rot: 0 }Layout Verification
The
DecouplingCapsPackingSolvercorrectly:Test Results
Closes #15