Improve decoupling capacitor layout#80
Conversation
|
@grantf04 is attempting to deploy a commit to the tscircuit Team on Vercel. A member of the Team first needs to authorize it. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d11c2e0a79
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| for (const [netConnKey, isNetConnected] of Object.entries( | ||
| this.inputProblem.netConnMap, | ||
| )) { | ||
| if (!isNetConnected) continue | ||
| const [p, n] = netConnKey.split("-") as [PinId, NetId] | ||
| if (p === connectedPinId) nets.add(n) |
There was a problem hiding this comment.
When a cap pin only gets its power net through the newly added one-hop strong connection path, that inferred net exists only inside getNetIdsForPin; ChipPartitionsSolver.createInputProblemFromPartition later copies only direct netConnMap entries for the cap pins and drops the strong edge to the main chip because the main chip is excluded from the decap partition. In those inputs, the cap is identified and moved into a decoupling_caps partition, but its inherited V/GND network is absent from the partition passed to PartitionPackingSolver, so the final partition packing cannot align that decap row to the corresponding power net.
Useful? React with 👍 / 👎.
|
Addressed the automated review feedback in 14c0e62: decap partitions now preserve inferred one-hop V/GND net connections from the main chip, with a regression test in |
|
@codex review |
|
Codex Review: Didn't find any major issues. Delightful! ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
Follow-up on the remaining red status: the only failing check is Vercel asking a tscircuit team member to authorize this fork deployment. The repo-owned CI checks are green: test, format-check, and type-check. I do not see a code-side failure to address there. |
1 participant
Summary
decoupling_capspartitions and place caps in a deterministic centered row with the configured decap gap/claim #15
Tests
npx --yes bun test tests/ChipPartitionsSolver.test.ts tests/IdentifyDecouplingCapsSolver/IdentifyDecouplingCapsSolver06.test.ts tests/PackInnerPartitionsSolver/SingleInnerPartitionPackingSolver.test.ts tests/LayoutPipelineSolver/RP2040Circuit.test.tsnpx --yes bun testnpx --yes bun run format:checknpx --yes tsc --noEmitnpx --yes bun run buildReview feedback addressed