fix: remove extra trace lines from duplicate segments#131
Open
blessuselessk wants to merge 1 commit intotscircuit:mainfrom
Open
fix: remove extra trace lines from duplicate segments#131blessuselessk wants to merge 1 commit intotscircuit:mainfrom
blessuselessk wants to merge 1 commit intotscircuit:mainfrom
Conversation
Two root causes for extra trace lines: 1. Within-trace: _applyBestRoute() concatenates path slices which can produce duplicate consecutive points (zero-length segments). Fixed by applying removeDuplicateConsecutivePoints after path concatenation. 2. Cross-trace: Multiple MSP pairs in the same net share a pin and get routed independently, producing overlapping segments near the shared pin. Fixed by trimming duplicate segments from the start/end of later traces within the same net at output time. Closes tscircuit#78
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
/claim #78
Summary
Fixes extra trace lines caused by two root causes:
Root Cause 1: Within-trace duplicate points
UntangleTraceSubsolver._applyBestRoute()concatenates path slices when replacing an L-shaped turn. The junction between old and new path can produce duplicate consecutive points (zero-length segments). Fixed by applyingremoveDuplicateConsecutivePointsafter concatenation.Root Cause 2: Cross-trace segment overlap
Multiple MSP pairs in the same net share a pin and get routed independently by
SchematicTraceSingleLineSolver2. Both routes draw through the same physical segment near the shared pin, producing visible duplicate lines. Fixed byremoveNetSegmentDuplicateswhich trims shared segments from the start/end of later traces within the same net.Changes
simplifyPath.ts: AddedremoveDuplicateConsecutivePointsutilityUntangleTraceSubsolver.ts: Apply dedup after path concatenation in_applyBestRouteremoveNetSegmentDuplicates.ts: New — trims duplicate segments between same-net tracesTraceCleanupSolver.ts: Apply cross-trace dedup at output timeTest plan