refactor: remove "Include shapes" toggle (closes #252)#253
Merged
Conversation
Spec for issue #252 — eliminate the global toggle, default all categories to circles, rely on the per-item shape picker for shape encoding.
12-task TDD plan tracking issue #252. Each task ends with a working build and tests passing; commits are frequent and scoped.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Exercises the full extract path (createParquetBundle -> extractSettings -> normalizeBundleSettings) to confirm a pre-issue-252 bundle carrying the removed includeShapes flag parses cleanly and never surfaces the field.
peymanvahidi
approved these changes
May 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
LegendPersistedSettings.includeShapesbecomes optional and@deprecated; legacy bundles still parse, new bundles drop the field on saveCloses #252.
Spec:
docs/superpowers/specs/2026-05-12-remove-include-shapes-toggle-design.mdPlan:
docs/superpowers/plans/2026-05-12-remove-include-shapes-toggle.md