refactor: control bar cleanup and filtering improvements#259
Draft
peymanvahidi wants to merge 15 commits into
Draft
refactor: control bar cleanup and filtering improvements#259peymanvahidi wants to merge 15 commits into
peymanvahidi wants to merge 15 commits into
Conversation
…lumbing Drops the Plane (XY/XZ/YZ) <select>, handlePlaneChange, the projection-plane-change CustomEvent, the projectionPlane @Property, and the cross-element assignment that pushed the plane onto the scatter-plot. Also drops projectionPlane? from ScatterplotElementLike. Helpers isProjection3D and getProjectionPlane are no longer imported here; they are deleted in a follow-up commit. The scatter-plot still owns its projectionPlane property in this commit; cleaned up next. Part of refactor for issue #196.
…gnment
Removes the projectionPlane Lit property, the xz/yz coordinate remap,
the point.z = coords[2] write (a write-only assignment with no readers),
and the projectionPlane entries in the _processData change-detection
gates. The data-processor call now passes four args; the unused fifth
parameter on data-processor itself is removed in a follow-up commit.
3D Parquet inputs now render using coords[0] / coords[1] only, matching
the historical default plane ('xy') that the property defaulted to in
production.
Part of refactor for issue #196.
Removes the projectionPlane parameter from DataProcessor.processVisualizationData and the conditional xz/yz coordinate remap. 3D projections now collapse to coords[0] / coords[1] on every code path. PlotDataPoint loses its optional z field; nothing consumed it (scatter-plot's only write was removed in the previous commit). Test changes: - Delete xz and yz plane-mapping tests. - Replace 'preserves z coordinate for 3D projections' with 'drops the z coordinate for 3D projections (rendered as 2D)', pinning the new contract. Part of refactor for issue #196.
…e helpers After the plane selector removal in earlier commits, these helpers have zero remaining callers in packages/ or app/. Removed both functions and their describe blocks from the test file. Part of refactor for issue #196.
…eric exclude path
…ders
The numeric filter's placeholder text showed the data's min/max
("min (4)", "max (1630)"). Removed at user request; placeholders are
now just "min" / "max". This also drops the now-unused
computeNumericBounds helper and the _dataBounds/_boundsAnnotation state
that only existed to feed those hints.
Owner
|
The filtering logic needs a complete revisit.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the 3D projection "Plane" (XY/XZ/YZ) dropdown and all
projectionPlaneplumbing from the web frontend. 3D Parquet files continue to load,zis silently discarded and onlyx/yare rendered. The PythonprotspaceCLI is unaffected.Changes:
handlePlaneChange,projection-plane-changeevent, theprojectionPlaneproperty, the cross-element assignment that pushed plane onto the scatter-plot, andprojectionPlane?fromScatterplotElementLike.projectionPlaneproperty, xz/yz coord remap,point.zwrite, andprojectionPlanefrom change-detection gates.DataProcessor.processVisualizationDatais now called with four args.projectionPlaneparameter and the xz/yz branch.PlotDataPointloses its optionalz?field. Tests updated: xz/yz mapping tests removed, "preserves z" test replaced with "drops the z coordinate for 3D projections."isProjection3DandgetProjectionPlanehelpers and their tests._updatePlotDataCoordinatesfast-path comment, it now correctly says "x/y" afterPlotDataPoint.zwas removed in commit 3.