Open
Conversation
Owner
|
Thanks but the fix should be to have the generated protos only use |
Author
|
Agreed. Alas, that dependency is harder to work with.
…On Thu, Jun 22, 2023, 18:15 Tristan Sloughter ***@***.***> wrote:
Thanks but the fix should be to have the generated protos only use ctx:t()
.
—
Reply to this email directly, view it on GitHub
<#6 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAADDBXWHPBOXXMPHAAQR4LXMRVQZANCNFSM6AAAAAAZP5HXNY>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Owner
|
Actually, this was fixed in 0.9.0 tsloughter/grpcbox_plugin@f88f6ae Are you on the latest version (0.9.0)? |
Author
|
apparently not... thx!
…On Thu, Jun 22, 2023, 21:12 Tristan Sloughter ***@***.***> wrote:
Actually, this was fixed in 0.9.0 ***@***.***
<tsloughter/grpcbox_plugin@f88f6ae>
Are you on the latest version (0.9.0)?
—
Reply to this email directly, view it on GitHub
<#6 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAADDBQC5DAMNFLNR23F5MLXMSKJHANCNFSM6AAAAAAZP5HXNY>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For some reason, files generated from
.protowithgpbrefers to bothctx:t()andctx:ctx()as types.This PR exports
ctx:ctx()so that this actually works.