Skip to content

Fix swapped A/B in connx_Tensor_is_likely_same_shape#95

Open
Hojun-Cho wants to merge 1 commit intotsnlab:masterfrom
Hojun-Cho:fix/tensor-broadcast-shape-check
Open

Fix swapped A/B in connx_Tensor_is_likely_same_shape#95
Hojun-Cho wants to merge 1 commit intotsnlab:masterfrom
Hojun-Cho:fix/tensor-broadcast-shape-check

Conversation

@Hojun-Cho
Copy link
Copy Markdown

A/B swapped in connx_Tensor_is_likely_same_shape.

A=[1,1,3,4], B=[3,4]

wrong: if (B->shape[0] != 1)  // B->shape[0] is 3, not 1, returns false
right: if (A->shape[0] != 1)  // A->shape[0] is 1, continues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant