Open
Conversation
Cause: xsk was zeroed memory, not NULL. Drop called xsk_socket__delete() on it. Fix: cleanup xsk in error path, set to NULL. Skip Drop if NULL. xsk_socket__delete: https://github.com/xdp-project/xdp-tools/blob/30f375169a7f0b44d4331589a0fe79631a8b79c2/lib/libxdp/xsk.c#L1359 xsk_socket__create_shared: https://github.com/xdp-project/xdp-tools/blob/master/lib/libxdp/xsk.c#L1268
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix FIXME: segfault when Nic::open() fails
Cause: xsk was heap-allocated zeroed memory, not NULL. Drop called xsk_socket__delete() on it.
Fix: use null_mut() instead of heap allocation. cleanup xsk in error path, set to NULL. Skip Drop if NULL.
xsk_socket__delete
xsk_socket__create_shared