Add custom filtering module by GyuBa · Pull Request #99 · tsnlab/packetvisor

GyuBa · 2026-01-29T06:34:23Z

No description provided.

…odule

pak-ji

Lint 에러 나는 부분도 처리부탁드립니다.

bpf/Makefile

bpf/packetvisor.bpf.c

bpf/packetvisor.bpf.h

bpf/packetvisor.bpf.c

pak-ji · 2026-02-01T23:22:09Z

bpf/packetvisor.bpf.h

+#define L3_FLAGS_IPV4 (1 << 0)
+#define L3_FLAGS_IPV6 (1 << 1)
+#define L3_FLAGS_EAPOL (1 << 2)
+#define L3_FLAGS_OTHER (1 << 3)


Layer 2, 4는 RESERVED인데 여기는 OTHER인 이유는 있을까요?

pak-ji · 2026-02-01T23:22:33Z

bpf/packetvisor.bpf.h

+/* L3 flags */
+#define L3_FLAGS_IPV4 (1 << 0)
+#define L3_FLAGS_IPV6 (1 << 1)
+#define L3_FLAGS_EAPOL (1 << 2)


Suggested change

#define L3_FLAGS_EAPOL (1 << 2)

pak-ji · 2026-02-01T23:31:26Z

src/lib.rs

+pub const L2_FLAGS_ETH: u32 = 1 << 0;
+pub const L2_FLAGS_VLAN: u32 = 1 << 1;
+pub const L2_FLAGS_ARP: u32 = 1 << 2;
+pub const L2_FLAGS_RESERVED: u32 = 1 << 3;
+
+pub const L3_FLAGS_IPV4: u32 = 1 << 0;
+pub const L3_FLAGS_IPV6: u32 = 1 << 1;
+pub const L3_FLAGS_EAPOL: u32 = 1 << 2;
+pub const L3_FLAGS_OTHER: u32 = 1 << 3;
+
+pub const L4_FLAGS_TCP: u32 = 1 << 0;
+pub const L4_FLAGS_UDP: u32 = 1 << 1;
+pub const L4_FLAGS_ICMP: u32 = 1 << 2;
+pub const L4_FLAGS_ICMPV6: u32 = 1 << 3;
+pub const L4_FLAGS_OTHER: u32 = 1 << 4;
+pub const L4_FLAGS_RESERVED: u32 = 1 << 5;
+
+#[repr(C)]
+#[derive(Clone, Copy, Debug, Default)]
+pub struct AfXdpRxConfig {
+    pub l2_flags: u32,
+    pub l3_flags: u32,
+    pub l4_flags: u32,
+}
+
+impl AfXdpRxConfig {
+    pub fn kernel_only() -> Self {
+        Self {
+            l2_flags: 0,
+            l3_flags: 0,
+            l4_flags: 0,
+        }
+    }
+
+    pub fn arp_filter() -> Self {
+        Self {
+            l2_flags: L2_FLAGS_ETH | L2_FLAGS_VLAN | L2_FLAGS_ARP,
+            l3_flags: 0,
+            l4_flags: 0,
+        }
+    }
+
+    pub fn vlan_filter() -> Self {
+        Self {
+            l2_flags: L2_FLAGS_VLAN,
+            l3_flags: 0,
+            l4_flags: 0,
+        }
+    }
+
+    pub fn l3_other_filter() -> Self {
+        Self {
+            l2_flags: L2_FLAGS_ETH | L2_FLAGS_VLAN,
+            l3_flags: L3_FLAGS_OTHER,
+            l4_flags: 0,
+        }
+    }
+
+    pub fn eapol_filter() -> Self {
+        Self {
+            l2_flags: L2_FLAGS_ETH | L2_FLAGS_VLAN,
+            l3_flags: L3_FLAGS_EAPOL,
+            l4_flags: 0,
+        }
+    }
+
+    pub fn tcp_udp_userspace_filter() -> Self {
+        Self {
+            l2_flags: L2_FLAGS_ETH | L2_FLAGS_VLAN,
+            l3_flags: L3_FLAGS_IPV4 | L3_FLAGS_IPV6,
+            l4_flags: L4_FLAGS_TCP | L4_FLAGS_UDP,
+        }
+    }
+}


lib.rs 내부가 아닌 다른 파일로 관리해주세요.

pak-ji · 2026-02-01T23:35:25Z

examples/echo/main.rs

        completion_ring_size,
        tx_ring_size,
        rx_ring_size,
+        Some(pv::AfXdpRxConfig::user_all()), // config_map initial value


구현하신 AfXdpRxConfig 내부에는 user_all이라는 메소드가 없습니다.

pak-ji · 2026-02-01T23:35:53Z

src/lib.rs

+        }
+    }
+
+    pub fn tcp_udp_userspace_filter() -> Self {


위에 메소드들이랑 이름을 비슷하게 지어주세요.

pak-ji · 2026-02-02T00:21:37Z

@GyuBa,

리니어 이슈랑 연결시켜주세요~!

bpf/packetvisor.bpf.c

pak-ji · 2026-02-02T08:37:59Z

bpf/packetvisor.bpf.c

+	}
+}
+
+static __always_inline bool match_ipv6_l4(void *nh, void *data_end, __u32 l4_flags)


Suggested change

static __always_inline bool match_ipv6_l4(void *nh, void *data_end, __u32 l4_flags)

static __always_inline bool match_l4_over_ipv6(void *nh, void *data_end, __u32 l4_flags)

pak-ji · 2026-02-02T08:38:12Z

bpf/packetvisor.bpf.c

+	}
+}
+
+static __always_inline bool match_ipv4_l4(void *nh, void *data_end, __u32 l4_flags)


Suggested change

static __always_inline bool match_ipv4_l4(void *nh, void *data_end, __u32 l4_flags)

static __always_inline bool match_l4_over_ipv4(void *nh, void *data_end, __u32 l4_flags)

pak-ji · 2026-02-02T08:49:50Z

bpf/packetvisor.bpf.c

+		if (snap->dsap == 0xaa && snap->ssap == 0xaa && snap->ctrl == 0x03) {
+			if (snap->oui[0] == 0x00 && snap->oui[1] == 0x00 && snap->oui[2] == 0x00) {


dsap, ssap, ctrl과 비교되는 0xaa, 0xaa, 0x03이 무엇인지 매크로로 정의부탁드립니다.

bpf/packetvisor.bpf.c

src/xdp_config.rs

pak-ji · 2026-02-02T08:59:01Z

src/lib.rs

+pub const L2_FLAGS_ETH: u32 = 1 << 0;
+pub const L2_FLAGS_VLAN: u32 = 1 << 1;
+pub const L2_FLAGS_ARP: u32 = 1 << 2;
+pub const L2_FLAGS_RESERVED: u32 = 1 << 3;
+
+pub const L3_FLAGS_IPV4: u32 = 1 << 0;
+pub const L3_FLAGS_IPV6: u32 = 1 << 1;
+pub const L3_FLAGS_EAPOL: u32 = 1 << 2;
+pub const L3_FLAGS_OTHER: u32 = 1 << 3;
+
+pub const L4_FLAGS_TCP: u32 = 1 << 0;
+pub const L4_FLAGS_UDP: u32 = 1 << 1;
+pub const L4_FLAGS_ICMP: u32 = 1 << 2;
+pub const L4_FLAGS_ICMPV6: u32 = 1 << 3;
+pub const L4_FLAGS_OTHER: u32 = 1 << 4;
+pub const L4_FLAGS_RESERVED: u32 = 1 << 5;
+
+#[repr(C)]
+#[derive(Clone, Copy, Debug, Default)]
+pub struct AfXdpRxConfig {
+    pub l2_flags: u32,
+    pub l3_flags: u32,
+    pub l4_flags: u32,
+}
+


얘들은 Impl AfXdpRxConfig 쪽으로 못빼나요?

Co-authored-by: pak-ji <pakji@tsnlab.com>

pak-ji · 2026-02-23T23:53:16Z

src/lib.rs

+#[repr(C)]
+#[derive(Clone, Copy, Debug, Default)]
+pub struct AfXdpRxConfig {
+    pub l2_flags: u32,
+    pub l3_flags: u32,
+    pub l4_flags: u32,
+}
+


xdp_config.rs로 빼주세요.

수정하였습니다.

xdp_config.rs에서 외부 모듈로 AfXdpRxConfig을 호출하지 않고, lib.rs에서 xdp_config.rs의 AfXdpRxConfig 구조체를 외부 모듈로 호출토록 해주세요.

넵 lib.rs에서 use:crate::xdp_config::AfXdpRxConfig로 호출하도록 수정했습니다.

pak-ji and others added 15 commits December 31, 2025 08:51

Add example xdp kernel module

dc6d51f

Add custom xdp module attach feature

f124b83

cargo fmt

7792958

Add example for passing user-space config values to Packetvisor XDP m…

a8cd6d3

…odule

cargo fmt

e0ba738

Add config-based packet forwarding direction control in XDP module

66acc96

Rename xdp module and add packetvisor config struct

e85a062

Fix packetvisor xdp module file name

11d7f06

Catch compile error

11c0346

Fix object file name

390795a

Fix config name and type to match userspace config

8dbe50a

add updating xsks_map on success

6bdec5a

Add protocol filtering

ce7cc23

Add EAPOL filtering

295b5c6

Apply L4 Filter for EAPOL

3f3b2c3

pak-ji requested changes Feb 1, 2026

View reviewed changes

GyuBa added 6 commits February 2, 2026 13:14

Update license info

9b8cb89

Fix typo

b776c15

Clean filter of protocol

b23d6e5

Fix BPF filtering

f04da62

Seperate preset about filter

bbb0fb8

Fix lint

6a96beb

GyuBa force-pushed the add-xdp-module branch from d7fbfbc to 6a96beb Compare February 2, 2026 05:56

GyuBa added 3 commits February 2, 2026 15:10

Use header of xdp_parsing_helper for vlan_hdr

8028656

Add comments

144cf7f

Update loca definition about network header

965ddc5

GyuBa force-pushed the add-xdp-module branch from d9e7e8f to 965ddc5 Compare February 2, 2026 07:32

pak-ji requested changes Feb 2, 2026

View reviewed changes

Fix Comments

9f330a0

Co-authored-by: pak-ji <pakji@tsnlab.com>

GyuBa added 6 commits February 12, 2026 16:54

Clean filter

f0ac051

Clean code

db779fa

Update Licensing

0b5f7bc

rename function

18a0e24

Filter macro into Impl AfXdpRxConfig

3bee570

Fix typo

34676b2

pak-ji reviewed Feb 23, 2026

View reviewed changes

Clean AfXdpRxConfig

05fb90b

GyuBa merged commit a19b7df into master Feb 24, 2026
0 of 2 checks passed

pak-ji deleted the add-xdp-module branch February 24, 2026 01:19

	static __always_inline bool match_ipv6_l4(void nh, void data_end, __u32 l4_flags)
	static __always_inline bool match_l4_over_ipv6(void nh, void data_end, __u32 l4_flags)

	static __always_inline bool match_ipv4_l4(void nh, void data_end, __u32 l4_flags)
	static __always_inline bool match_l4_over_ipv4(void nh, void data_end, __u32 l4_flags)

		if (snap->dsap == 0xaa && snap->ssap == 0xaa && snap->ctrl == 0x03) {
		if (snap->oui[0] == 0x00 && snap->oui[1] == 0x00 && snap->oui[2] == 0x00) {

Conversation

GyuBa commented Jan 29, 2026

Uh oh!

pak-ji left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

pak-ji commented Feb 2, 2026

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants