Open
Conversation
tsorya
pushed a commit
that referenced
this pull request
Jan 14, 2024
…lude VIPS and UMA (openshift#5554) This is a combination of 2 commits. This is the 1st commit message: MGMT-14416: VipDhcpAllocation from update params should take precedence (openshift#5209) This change fixes a case where UserManagedNetworking and VipDhcpAllocation are being changed at the same API update. The ValidateClusterUpdateVIPAddresses func will now use VipDhcpAllocation from update params, if relevant, before taking the DB cluster VipDhcpAllocation into account. Additionally, an additional error surfaced while fixing the aforementioned issue, displaying a "User Managed Networking cannot be set with API VIP" to the user. This change will also handle such a scenario by clearing up API and Ingress VIPs that were set by DHCP, in case the user switched to 'User Managed Networking'. This is the commit message #2: MGMT-15306: Fix UpdateCluster for requests that include VIPS and UMA (openshift#5547) This fix handles cluster updates that patch UMN and VIPs at the same request. There was an issue in which the code overrode an empty VIPs array (which is how VIPs should get deleted) with a nil, indicating no update to this field. This change also includes tests that validate those exact scenarios.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.