This repository was archived by the owner on Jul 17, 2020. It is now read-only.
Fix libs and plugins detection without local package.json#367
Open
artch wants to merge 1 commit intotststs:masterfrom
Open
Fix libs and plugins detection without local package.json#367artch wants to merge 1 commit intotststs:masterfrom
artch wants to merge 1 commit intotststs:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is expected: If the local project folder does not have
package.jsonandnode_modules, the libs and plugins detection should skip it and go toatom-ternjs/node_modulespackage.What is happening: If the local project folder does not have
package.jsonandnode_modules, it throws an errorCannot find module tern-mylib, despite it is present inatom-ternjs/node_modules/tern-mylib.This PR fixes this using an additional try/catch block.