[python] feature: upgrade packages when deploying#42
Open
lucasts wants to merge 1 commit intotsuru:masterfrom
Open
[python] feature: upgrade packages when deploying#42lucasts wants to merge 1 commit intotsuru:masterfrom
lucasts wants to merge 1 commit intotsuru:masterfrom
Conversation
Member
|
LGTM but would like to have more opnions regarding the point mentioned in the warning. In my opnion we should favor users that follow the best practices (those would not have problems, if I understood correctly). |
lucasts
force-pushed
the
feat/upgrade-packages
branch
from
294a981 to
37050eb
Compare
Contributor
Author
|
@andrestc agreed. Tsuru servers admins can choose to warn users about this change and allow them some time to check and update their requirements/setup if necessary. |
lucasts
changed the title
Member
|
I agree. Correct if I'm wrong, but if someone run into problems with this, he can fix it by setting specific dependency versions in |
Contributor
Author
|
@ggarnier that's correct. |
ggarnier
approved these changes
Aug 7, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
enable pip to upgrade packages which changed since last deploy.
also, will avoid cleaning up app's images manually
This can lead to problems to apps careless about their packages versions.