Open
Conversation
anna-irena-nowak
left a comment
anna-irena-nowak
left a comment
There was a problem hiding this comment.
Does this PR going to be pushed upstream at some point? If not, why do we have so many configurations that are going to be built?
.travis.yml
Outdated
| env: PATH="/usr/bin:$PATH" TEST=analyze | ||
| # - os: linux | ||
| # compiler: gcc | ||
| # env: CUDA=8.0.61-1 |
There was a problem hiding this comment.
commented out stuff can be removed
.travis.yml
Outdated
| dist: trusty | ||
| env: FEATURES="--enable-memcached" | ||
| - os: linux | ||
| compiler: clang |
There was a problem hiding this comment.
what does that mean? Does it compile with clang, or for clang? Does ccache have to be compiled for certain compiler?
Author
There was a problem hiding this comment.
Documentation of travis says that are tests suits agains clang/gcc: https://docs.travis-ci.com/user/languages/c/
I removed other linux entries - Left only those added by Martin.
There was a problem hiding this comment.
It's still not entirely clear to me, but I can figure it out later not to block this PR.
anna-irena-nowak
approved these changes
Aug 2, 2018
Member
|
These are default settings from upstream so we should keep them to ensure nothing is broken due to our changes
Von meinem iPhone gesendet
… Am 02.08.2018 um 14:56 schrieb Anna Nowak ***@***.***>:
@wiorka approved this pull request.
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub, or mute the thread.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.