Correct rhs index in not_a_knot right boundary condition#30
Open
gistrec wants to merge 1 commit into
Open
Conversation
rhs[0] was written instead of rhs[n-1], silently overwriting the left boundary condition value when m_right == not_a_knot
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
When using
not_a_knotas the right boundary condition together witha non-zero left boundary condition (
first_derivorsecond_deriv),the left BC value was silently ignored
Root cause:
set_points()wroterhs[0] = 0.0instead ofrhs[n-1] = 0.0inside thenot_a_knotright-BC branch. Thisoverwrote whatever the left-BC block had stored in
rhs[0]a fewlines earlier
The bug did not affect the symmetric case (
not_a_knoton both sides)because
rhs[0]was already 0 there, so the overwrite was a no-op.That is also why no existing test caught it
Fix
src/spline.h, line 332: changerhs[0]torhs[n-1]Test
Added
MixedBoundaryNotAKnottounit_tests.cpp. It verifies that:second_derivleft +not_a_knotright:f''(x[0])matches the requested value.first_derivleft +not_a_knotright:f'(x[0])matches the requested value.Both assertions fail on the unfixed code and pass after the fix