Fix PostgreSQL CREATE INDEX race condition on container startup (v2.5.62)#34
Merged
ttlequals0 merged 2 commits intomainfrom Feb 15, 2026
Merged
Fix PostgreSQL CREATE INDEX race condition on container startup (v2.5.62)#34ttlequals0 merged 2 commits intomainfrom
ttlequals0 merged 2 commits intomainfrom
Conversation
….62) Replace fcntl.flock file lock with PostgreSQL advisory lock for migration coordination. File locks only work within a single container /tmp filesystem, so the app and celery-worker containers raced against each other on every restart, causing duplicate key value violates unique constraint pg_class_relname_nsp_index errors per restart event. Advisory locks work across all connections to the same PostgreSQL database. Winner process runs migrations while others block and skip. Falls back to uncoordinated execution if advisory lock fails (each DDL statement already has its own idempotency handling).
Schedule CRUD endpoints caught only ImportError from reload_schedules_task.delay(), but when the app module is imported first (resolving a circular import), the Celery task loads successfully and .delay() fails with a Redis ConnectionError instead. Widen to catch Exception so schedule operations succeed regardless of Celery/Redis availability. Also refactor migration lock tests to avoid importing app module directly (prevents Celery initialization side effects).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan