Fix healthcheck pings blocked by SSRF protection (v2.5.66)#37
Merged
ttlequals0 merged 2 commits intomainfrom Feb 25, 2026
Merged
Fix healthcheck pings blocked by SSRF protection (v2.5.66)#37ttlequals0 merged 2 commits intomainfrom
ttlequals0 merged 2 commits intomainfrom
Conversation
Add TRUSTED_INTERNAL_HOSTS env var to allowlist hostnames and CIDR ranges that should bypass SSRF private-IP blocking. Healthcheck servers on private networks were blocked since v2.5.64.
Use Union[X, Y] instead of X | Y (PEP 604 requires Python 3.10+).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
validate_safe_url()blocked requests to healthcheck servers that resolve to private IPsTRUSTED_INTERNAL_HOSTSenvironment variable that lets admins allowlist hostnames and/or CIDR ranges to bypass SSRF private-IP blockingChanges
pixelprobe/utils/security.py-- Added_load_trusted_hosts(),_reset_trusted_hosts(),_is_trusted()helpers; updatedvalidate_safe_url()to check allowlist before blockingconfig.py-- AddedTRUSTED_INTERNAL_HOSTSconfig variabledocker-compose.yml-- Added env var to bothpixelprobeandcelery-workerservicesdocs/CONFIGURATION.md-- Added "SSRF Trusted Hosts" documentation sectionversion.py-- Bumped to 2.5.66tests/test_security_fixes.py-- Added 8 new tests for trusted hosts allowlistTest plan
2.5.66+latestTRUSTED_INTERNAL_HOSTSin container env and verify healthcheck pings succeed in Grafana logs