Skip to content

5.1.0 release exposes compose officially.#12

Merged
edward-jazzhands merged 5 commits into
ttygroup:mainfrom
KRRT7:main
Jul 31, 2025
Merged

5.1.0 release exposes compose officially.#12
edward-jazzhands merged 5 commits into
ttygroup:mainfrom
KRRT7:main

Conversation

@KRRT7

@KRRT7 KRRT7 commented Jul 31, 2025

Copy link
Copy Markdown
Contributor

No description provided.

@KRRT7 KRRT7 requested a review from edward-jazzhands as a code owner July 31, 2025 10:17
@edward-jazzhands

edward-jazzhands commented Jul 31, 2025

Copy link
Copy Markdown
Member

Hey thanks for the PR. I think this is a good idea but it would require changing a few more things because it would mean the library can only run on Textual 5. So the project dependencies and testing would all need to be bumped up to Textual >= 5.0.0 as well. Now that I know about it, it might make more sense for me to just do that myself though, unless you really want the PR

@edward-jazzhands edward-jazzhands left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change is good but we'd also need to update pyproject.toml and noxfile.py

@KRRT7

KRRT7 commented Jul 31, 2025

Copy link
Copy Markdown
Contributor Author

the dependencies need to be updated to >= 5.1.0 in that case, it's not compatible with 5.0.0

@edward-jazzhands edward-jazzhands left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea with the minor revision testing. Im a bit new to environment testing but this made me realize its pretty typical to test minor versions specifically to pinpoint which one you need instead of just saying "Latest 5.x.x"

@edward-jazzhands edward-jazzhands merged commit e96470e into ttygroup:main Jul 31, 2025
1 check passed
@KRRT7

KRRT7 commented Jul 31, 2025

Copy link
Copy Markdown
Contributor Author

yeah It’s common to test specific minor versions to pinpoint the minimum required version instead of just saying “latest 5.x.x.” Typically, only the latest major version (e.g. 5.x) is tested, not older ones like 4.x or 3.x, to avoid the maintenance burden.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants