ConfigParser only stores config data#53
Open
bakhtos wants to merge 10 commits intotuhh-softsec:mainfrom
Open
Conversation
it is inserted by dfd_extraction.py
It is now part of technology_switch.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR simplifies the responsibilities of the
ConfigParserobject used internally:Communications_tech_listis not given in config, it is now part oftechnology_switchcodecontainer_tech_listwhich bundles togethermaven,gradleanddocker-composeused to detect microservices, allowing it to be extended in the future with more technologiestemp.tmp.tmp_configis nowcore.config.code2dfd_configcommitfield is now part ofRepositorygroup, notAnalysis settings; the latter IMO should be left for code2DFD-internal thingsDFDis not stored as a string inConfigParser, it is now adictofmicroservices,information_flowsandexternal_componentsas an intermediate step before migrating to proper objectsdfdobject and get the necessary parts internally when necessary, in the end they set the updated datastructurestechnology_switchis not used as a getter for services/information_flows, the functions are renamed toset_microservicesandset_information_flowsand are only called once, in the appropriate place inDFD_extraction, all other functions get the data from thedfddictionary directly