Release v2.4.11#5540
Merged
Merged
Conversation
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
…dding column A raster ImageView placed at Pos.Right of a view that has a right Padding column overwrites that padding column (the cell one to the LEFT of the ImageView's frame) when it redraws. The full first draw repaints the neighbour so it looks correct; a partial redraw (a focus round-trip) leaves the overwrite behind. Surfaced in winprint as the page-preview pane bleeding its canvas colour into the settings panel's seam (on both Sixel and Kitty). Not actually raster-specific — a plain View at Pos.Right reproduces it too — so the fix likely belongs in the View draw/clip path. Test currently FAILS (reproduces #5518). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Thickness.Draw fills the adornment via the driver's CurrentAttribute and never sets one itself, relying on the caller having set it. The parent's ClearViewport (SetAttributeForRole) used to do that right before adornments drew. Since #5358 the parent skips its ClearViewport on a child-only redraw, so the Padding adornment inherited a stale CurrentAttribute — e.g. Color.None left by a sibling raster ImageView's transparent-marking — and filled the padding column with foreign content (the seam-overdraw winprint reported, on both Sixel and Kitty). Set the view's Normal attribute before the no-subview Padding.Thickness.Draw so the fill is deterministic regardless of prior draw state. Does not touch the #5358 clear optimization. Full parallelizable (17449) + non-parallelizable (74) suites stay green; the #5518 repro test now passes. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Bound UICatalog in-memory log capture to stop long-run memory growth
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d7cc579852
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
This was referenced Jun 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release v2.4.11
Version:
2.4.11NuGet Package:
Terminal.Gui 2.4.11What happens when this PR is merged
v2.4.11main→developwill be openedChecklist
2.4.11