Fix Firestore rules validation for raphcon creation

[Copilot]

Raphcon creation was failing with "Missing or insufficient permissions" because the Firestore rules validation function only checked for 3 fields while the application sends 5 required fields plus 1 optional field.

Changes

• Updated isValidRaphcon() in firestore.rules to validate all fields sent by RaphconModel.toMap():
  • Added type (string, required)
  • Added isActive (boolean, required)
  • Added comment (string, optional)

Before

function isValidRaphcon(data) {
  return data.keys().hasAll(['userId', 'createdAt', 'createdBy']) &&
         data.userId is string &&
         data.createdAt is timestamp &&
         data.createdBy == request.auth.uid;
}

After

function isValidRaphcon(data) {
  return data.keys().hasAll(['userId', 'createdAt', 'createdBy', 'type', 'isActive']) &&
         data.userId is string &&
         data.createdAt is timestamp &&
         data.createdBy == request.auth.uid &&
         data.type is string &&
         data.isActive is bool &&
         (!data.keys().hasAny(['comment']) || data.comment is string);
}

Original prompt

---

This section details on the original issue you should resolve

<issue_title>Fix Firestore permission error when adding raphcons</issue_title>
<issue_description>When trying to add a raphcon, the operation fails due to missing or insufficient permissions in Firestore.

Error message:

Ich glaube, dass eine Firestore-Regel angepasst werden muss, um das Hinzufügen von raphcons zu ermöglichen.

Steps to Reproduce:

1. Versuche, einen raphcon hinzuzufügen.
2. Die Fehlermeldung erscheint.

Expected behavior:

• Raphcons sollten ohne Permission Error hinzugefügt werden können.

Possible solution:

• Überprüfe Firestore-Regeln und passe sie ggf. an, damit das Hinzufügen der raphcons möglich ist.</issue_description>

Comments on the Issue (you are @copilot in this section)

• Fixes Fix Firestore permission error when adding raphcons #40

---

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

[github-actions]

Visit the preview URL for this PR (updated for commit 53468d1):

https://angryraphi--pr41-copilot-fix-firestor-leg0ew4e.web.app

_{(expires Mon, 22 Dec 2025 23:49:40 GMT)}

_{🔥 via Firebase Hosting GitHub Action 🌎}

_{Sign: a0d0f39c5de51b5f0e7b4994943c4eea410f181e}

[sonarqubecloud]

Quality Gate failed

Failed conditions
36.6% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud