LPDDR6 implementation#137
Draft
marcomoerz wants to merge 47 commits into
Draft
Conversation
removed opcode support
| else if constexpr (std::is_same_v<T, DRAMUtils::MemSpec::MemSpecLPDDR6>) | ||
| { | ||
| MemSpecLPDDR6 ddr (static_cast<DRAMUtils::MemSpec::MemSpecLPDDR6>(arg)); | ||
| result = std::make_unique<LPDDR6>(ddr); |
Collaborator
There was a problem hiding this comment.
Warum bekommt LPDDR6 keine simconfig?
| COUNT, // 23 | ||
| }; | ||
|
|
||
| namespace CmdTypeUtil |
Collaborator
There was a problem hiding this comment.
Müssen die restlichen Funktionen hier nicht auch erweitert werden?
| bitset[n] = patternApplyBitSpec(settings, descriptor, ((lastpattern >> n) & 1) == 1, column_bits[10]); | ||
| break; | ||
| case C11: | ||
| bitset[n] = column_bits[C11]; |
Collaborator
There was a problem hiding this comment.
column_bits[11] oder column_bits[C11]?
| struct command_stats_t : public util::Serialize, public util::Deserialize { | ||
| uint64_t act = 0; | ||
| uint64_t pre = 0; | ||
| uint64_t preSameBank = 0; |
Collaborator
There was a problem hiding this comment.
Warum gibt es ein Stat für Same-Bank Precharge aber nicht All-Bank Precharge?
| uint64_t refAllBank = 0; | ||
| uint64_t refPerBank = 0; | ||
| uint64_t refPerTwoBanks = 0; | ||
| uint64_t refSameBank = 0; |
Collaborator
There was a problem hiding this comment.
Fehlt hier nicht noch der neue Refresh?
| @@ -0,0 +1,155 @@ | |||
| #ifndef DRAMPOWER_STANDARDS_LPDDR6_LPDDR6INTERFACE_H | |||
Collaborator
There was a problem hiding this comment.
Wo wird das CS-Signal modelliert?
| #include "DRAMPower/simconfig/simconfig.h" | ||
|
|
||
| #include <array> | ||
| #include <stdint.h> |
| case BG1: | ||
| bitset[n] = bank_group_bits[1]; | ||
| break; | ||
| case DBG0: |
Collaborator
There was a problem hiding this comment.
Wird das anders gehandhabt oder ist die Zuweisung falsch?
| std::bitset<2> bank_bits(targetCoordinate.bank & 0x3); | ||
| std::bitset<17> row_bits(targetCoordinate.row & 0x1FFFF); | ||
| std::bitset<6> column_bits(targetCoordinate.column & 0x3F); | ||
| std::bitset<2> bank_group_bits(targetCoordinate.bankGroup & 0x2); |
| std::bitset<2> bank_group_bits(targetCoordinate.bankGroup & 0x2); | ||
| auto dbank = targetCoordinate.dbank.value_or((targetCoordinate.bank + extraData.perTwoBankOffset) % extraData.numberOfBanks); | ||
| auto dbankGroup = dbank / 4; // TODO enforce | ||
| std::bitset<2> dbank_group_bits(dbankGroup & 0x2); |
Collaborator
There was a problem hiding this comment.
Warum & 0x2? Und die Variable wird nicht benutzt.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.