Quote Engine Non-CDN Retrieval#48
Open
wazaundtechnik wants to merge 4 commits into
Open
Conversation
wazaundtechnik
force-pushed
the
feature/quote-nxt
branch
from
600c701 to
1a159c7
Compare
wazaundtechnik
changed the title
|
@wazaundtechnik since you said using raw Github is enough for our usage, is this PR still relevant? |
Contributor
Author
|
This PR allows hot reload every arbitrary interval (default to 5
minutes). Previously, reload only happens on program startup. So yes,
this PR is still relevant.
|
|
@wazaundtechnik wow that's cool. okay then. can @fushar take a look at this PR too? now that we have another user (beside our own group) maybe it's time to work on this again hehe. |
There was a problem hiding this comment.
can you please use a more descriptive name? it's not obvious what qe stands for.
There was a problem hiding this comment.
before that, why did you put this as fixture? as I understand it, this is your system under test. shouldn't you explicitly instantiate QuoteEngine inside your test case and not provide this as fixture? this is not going to be used anywhere else (at least for now).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Too tired today... still WIP. I will update this later.
Update: Done everything. Finally!