Open
Conversation
Owner
|
Hi @NullOranje , thanks a lot for contributing! However I don't think the change is a good fit for this library. The only reason I have is that the library is aim to be small and only have small dependencies, so that it can be used in embedded environment as well. While the PR doesn't introduce a lot of new code, it does indeed introduce one big dependencies that is Poison. I'd be happier to separate the package into |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implementation of DNS Queries over HTTPS (DOH). Uses RFC 8484 POST request only.