Skip to content

post interaction button changes#809

Closed
ThatOneCalculator wants to merge 4 commits intotunjid:mainfrom
ThatOneCalculator:fix/interact-buttons
Closed

post interaction button changes#809
ThatOneCalculator wants to merge 4 commits intotunjid:mainfrom
ThatOneCalculator:fix/interact-buttons

Conversation

@ThatOneCalculator
Copy link
Contributor

@ThatOneCalculator ThatOneCalculator commented Jan 4, 2026

Before After
image image

Btw this will probably be my last PR/commit for today, will wrap up loose ends with the other PRs tomorrow :)

@gemini-code-assist
Copy link

Summary of Changes

Hello @ThatOneCalculator, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refines the user interface for post interaction buttons by re-introducing previously lost changes and updating the 'More Options' button icon. The visual change replaces an upward arrow with a more conventional three-dot vertical ellipsis, alongside a minor adjustment to the size of action icons within text-with-embed presentations, aiming for a cleaner and more intuitive user experience.

Highlights

  • Icon Change for 'More Options' Button: The 'More Options' button icon has been updated from an ArrowCircleUp (upward arrow) to MoreVert (three vertical dots) for improved clarity and standard UI representation. This change was re-applied from a previous PR (use common Share icon instead of ArrowCircleUp #794) that was overridden.
  • Re-application of Previous Changes: This pull request re-applies changes related to post interaction buttons that were inadvertently lost due to a force push, ensuring the intended UI updates are present.
  • Action Icon Size Adjustment: The size of action icons for Timeline.Presentation.Text.WithEmbed has been slightly increased from 16.dp to 18.dp to enhance visibility.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request successfully re-applies previous changes and updates the 'more options' button icon to the standard MoreVert icon, which improves UI consistency. The changes are straightforward and correct. I've added a couple of suggestions on PostInteractions.kt to further enhance UI consistency by aligning with Material Design sizing guidelines and using consistent content descriptions for icons.

@tunjid
Copy link
Owner

tunjid commented Jan 5, 2026

This PR changes quite a bit, some we've already discussed and some new. Its should be split so we can discuss the merits of each individually.

  • Share button icon: I'd like to hold off changes to this until moderation features are completed. @joelmuraguri is working on this.
  • Haptics: This should be a user configurable option. The Preferences data structure might need some refactoring to accommodate this, and that option will need to be piped through the app layers to this button.
  • Interaction button pop: I'm good with this change for now. The long term plan for this is to use lottie animations for this: https://lottiefiles.com/free-animations/like. However integrating lottie is on the backlog, there are higher priority things to work on. The pop animation is a good stop gap. The scale should be applied using Modifier.graphicsLayer { } for performance reasons however.

@ThatOneCalculator
Copy link
Contributor Author

To address each bullet point:

@ThatOneCalculator ThatOneCalculator deleted the fix/interact-buttons branch January 5, 2026 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants