post interaction button changes#809
Conversation
Summary of ChangesHello @ThatOneCalculator, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request refines the user interface for post interaction buttons by re-introducing previously lost changes and updating the 'More Options' button icon. The visual change replaces an upward arrow with a more conventional three-dot vertical ellipsis, alongside a minor adjustment to the size of action icons within text-with-embed presentations, aiming for a cleaner and more intuitive user experience. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request successfully re-applies previous changes and updates the 'more options' button icon to the standard MoreVert icon, which improves UI consistency. The changes are straightforward and correct. I've added a couple of suggestions on PostInteractions.kt to further enhance UI consistency by aligning with Material Design sizing guidelines and using consistent content descriptions for icons.
ui/timeline/src/commonMain/kotlin/com/tunjid/heron/timeline/ui/post/PostInteractions.kt
Show resolved
Hide resolved
ui/timeline/src/commonMain/kotlin/com/tunjid/heron/timeline/ui/post/PostInteractions.kt
Show resolved
Hide resolved
|
This PR changes quite a bit, some we've already discussed and some new. Its should be split so we can discuss the merits of each individually.
|
|
To address each bullet point:
|
ArrowCircleUptoMoreVert(3 dots) forMoreOptionsbutton (re-up of use common Share icon instead of ArrowCircleUp #794)Btw this will probably be my last PR/commit for today, will wrap up loose ends with the other PRs tomorrow :)