libsql-server: Don't fail namespace load on corrupt stats file#2255
Open
penberg wants to merge 1 commit into
Open
libsql-server: Don't fail namespace load on corrupt stats file#2255penberg wants to merge 1 commit into
penberg wants to merge 1 commit into
Conversation
If the server loses power, the stats file can end up empty because
the stats persist loop did not sync the file to disk before renaming
it over the old one. On restart, the stats file failed to parse,
which errored out namespace load, and took the whole server down:
Error: Internal Error: `EOF while parsing a value at line 1 column 0`
Caused by:
EOF while parsing a value at line 1 column 0
Stats are disposable telemetry, so fall back to default stats with a
warning when the stats file does not parse, and sync the stats file
to disk before renaming it to close the truncation window.
Fixes #2254
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the server loses power, the stats file can end up empty because the stats persist loop did not sync the file to disk before renaming it over the old one. On restart, the stats file failed to parse, which errored out namespace load, and took the whole server down:
Stats are disposable telemetry, so fall back to default stats with a warning when the stats file does not parse, and sync the stats file to disk before renaming it to close the truncation window.
Fixes #2254