Skip to content

@tus/azure-store: fix metadata parsing bug #790

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
osarogie wants to merge 5 commits into
base: main
Choose a base branch
from
Open

@tus/azure-store: fix metadata parsing bug #790

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
d3706e2
fix validation exception
osarogie Sep 8, 2025
a224979
Add changeset
Murderlon Sep 24, 2025
37cdb53
Merge branch 'tus:main' into patch-1
osarogie Feb 24, 2026
5461fc0
Refactor metadata handling in AzureStore to ensure proper parsing of …
osarogie Feb 24, 2026
20a36b4
eslint fix
osarogie Feb 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/small-pillows-hug.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@tus/azure-store": patch
---

Fix metadata parsing bug
10 changes: 9 additions & 1 deletion packages/azure-store/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,15 @@ export class AzureStore extends DataStore {
const upload = JSON.parse(propertyData.metadata.upload) as Upload
// Metadata is base64 encoded to avoid errors for non-ASCII characters
// so we need to decode it separately
upload.metadata = Metadata.parse(JSON.stringify(upload.metadata ?? {}))
let metadataStr
if (typeof upload.metadata === 'string') {
metadataStr = upload.metadata
} else if (upload.metadata && typeof upload.metadata === 'object') {
metadataStr = JSON.stringify(upload.metadata ?? {})
} else {
metadataStr = '{}'
}
upload.metadata = Metadata.parse(metadataStr)
Comment on lines +120 to +128
Copy link
Member

@Murderlon Murderlon Feb 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is overprotective for no reason? It should be as simple as this? Maybe undefined instead of {} not sure.

Suggested change
let metadataStr
if (typeof upload.metadata === 'string') {
metadataStr = upload.metadata
} else if (upload.metadata && typeof upload.metadata === 'object') {
metadataStr = JSON.stringify(upload.metadata ?? {})
} else {
metadataStr = '{}'
}
upload.metadata = Metadata.parse(metadataStr)
upload.metadata = upload.metadata ? Metadata.parse(JSON.stringify(upload.metadata)) : {}

Copy link
Author

@osarogie osarogie Feb 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There were cases when upload.metadata was already a string.
That's why I added this check

    if (typeof upload.metadata === 'string') {
      metadataStr = upload.metadata
    }

I could simplify it to look like this

    let metadataStr
    if (typeof upload.metadata === 'string') {
      metadataStr = upload.metadata
    } else if (upload.metadata && typeof upload.metadata === 'object') {
      metadataStr = JSON.stringify(upload.metadata ?? {})
    }
    upload.metadata = metadataStr ? Metadata.parse(metadataStr) : {}


await this.cache.set(appendBlobClient.url, upload)

Expand Down