feat(analyze): show free disk space in overview header#690
Closed
sebastianbreguel wants to merge 3 commits intotw93:mainfrom
Closed
feat(analyze): show free disk space in overview header#690sebastianbreguel wants to merge 3 commits intotw93:mainfrom
sebastianbreguel wants to merge 3 commits intotw93:mainfrom
Conversation
Display available disk space next to "Analyze Disk" title so users immediately see how much room they have before exploring locations. Uses syscall.Statfs with Bavail (excludes reserved blocks) and degrades gracefully if the call fails.
Statfs now checks the actual volume being analyzed, so free space is accurate when scanning external drives or non-root volumes.
tw93
reviewed
Apr 7, 2026
Owner
tw93
left a comment
tw93
left a comment
There was a problem hiding this comment.
Looks good overall. One missing piece before merge: add a focused regression test in cmd/analyze that verifies the overview header shows the free-space suffix when diskFree > 0 and omits it when unavailable. This PR changes View() output, so that rendering path should have direct coverage.
Contributor
Author
|
@tw93 thanks for the comments, ready! |
Owner
|
@sebastianbreguel thanks for the follow-up here. This is already on now, so there is nothing left to merge from this branch. Closing this PR out. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
syscall.StatfswithBavail(excludes reserved blocks)diskFree > 0)humanizeByteshelper for formattingBefore:
Analyze DiskAfter:
Analyze Disk (123.4 GB free)Safety Review
Statfssyscall at startup, display-only output.Tests
go test ./cmd/analyze/)