Skip to content

Docs: fix dark offcanvas dismiss attribute#42706

Draft
Kevinjohn wants to merge 1 commit into
twbs:mainfrom
Kevinjohn:fix-offcanvas-dark-dismiss
Draft

Docs: fix dark offcanvas dismiss attribute#42706
Kevinjohn wants to merge 1 commit into
twbs:mainfrom
Kevinjohn:fix-offcanvas-dark-dismiss

Conversation

@Kevinjohn

@Kevinjohn Kevinjohn commented Jul 19, 2026

Copy link
Copy Markdown

Description

Fixes the dark offcanvas example's close button dismiss attribute.

Motivation & Context

The copied dark offcanvas example used data-bs-dismiss="offcanvasDark", but Bootstrap's dismiss trigger listens for data-bs-dismiss="offcanvas". When the example is used in a live offcanvas, clicking the close button does not dismiss the component.

Expected: clicking the close button dismisses the offcanvas.
Actual: the offcanvas remains shown because the dismiss selector does not match.

Type of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (non-breaking change)
  • Breaking change (fix or feature that would change existing functionality)

Checklist

  • I have read the contributing guidelines
  • My code follows the code style of the project (using npm run lint)
  • My change introduces changes to the documentation
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed

Live previews

Related issues

None.

Checks

  • git diff --check
  • npm exec -- prettier --config site/.prettierrc.json -c site/src/content/docs/components/offcanvas.mdx
  • npm run docs-build

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants