Docs: use concrete checks and radios aria labels#42708
Draft
Kevinjohn wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Replaces placeholder accessible names in the checks and radios "Without labels" example.
Motivation & Context
The example explains that controls without visible labels still need an accessible name, but the copied markup used literal
aria-label="..."values.Expected: the example uses concrete accessible names.
Actual: the example exposes
...as the checkbox and radio accessible names.This updates the example to use concrete labels for the checkbox and radio inputs.
Type of changes
Checklist
npm run lint)Live previews
Related issues
None.
Checks
git diff --checknpm exec -- prettier --config site/.prettierrc.json -c site/src/content/docs/forms/checks-radios.mdxnpm run docs-build