feat: append comment to the Response element#797
Open
wsabol wants to merge 8 commits intotwilio:mainfrom
Open
Conversation
tiwarishubham635
added
the
type: community enhancement
Contributor
|
Hi @wsabol! I am taking a look at it |
Contributor
|
I can see the files VoiceResponse and Comment should be autogenerated from our internal tool yoyodyne as you can see the lines here. I will check what changes need to be done there for this. Thanks! |
Contributor
|
Created an internal ticket for this |
Author
|
any update on this? |
…ssue-796-append-comment # Conflicts: # src/Twilio/TwiML/VoiceResponse.php
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #796
Closes #796
Fixes
This PR allows you to append a xml comment to a VoiceResponse object.
Checklist