authentication#594
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## trunk #594 +/- ##
==========================================
Coverage 100.00% 100.00%
==========================================
Files 48 63 +15
Lines 3981 4857 +876
Branches 182 201 +19
==========================================
+ Hits 3981 4857 +876 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
- move memory session store to its own dedicated package - implement MemoryAccountStore (i.e. ISimpleAccount/ISimpleAccountBinding authorizers)
at least on pypy3.9, typing.Protocol appears to runtime-check its args to make sure they are all TypeVars (i.e. not ParamSpecs)
gkrnours
reviewed
Jul 24, 2026
gkrnours
reviewed
Jul 24, 2026
gkrnours
reviewed
Jul 24, 2026
gkrnours
reviewed
Jul 24, 2026
…r than printing them
Member
Author
|
@gkrnours In the course of fixing the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The sessions layer is missing some stuff. This is an omnibus PR that adds it, and will add docs for it.
I would recommend starting the review by looking through the new documentation at https://klein--594.org.readthedocs.build/en/594/ — specifically https://klein--594.org.readthedocs.build/en/594/introduction/3-forms.html and https://klein--594.org.readthedocs.build/en/594/introduction/4-auth.html .
It's probably too big to land as-is. In fact, some parts of this are probably entirely new, separate projects that should be a dependency.Some of this stuff might be worth spinning out, but looking at the documentation, it would be difficult to land it piecemeal and get a cohesive story about what it's all for.