Skip to content

authentication#594

Merged
glyph merged 99 commits into
trunkfrom
lots-more-docs
Jul 24, 2026
Merged

authentication#594
glyph merged 99 commits into
trunkfrom
lots-more-docs

Conversation

@glyph

@glyph glyph commented May 18, 2023

Copy link
Copy Markdown
Member

The sessions layer is missing some stuff. This is an omnibus PR that adds it, and will add docs for it.

I would recommend starting the review by looking through the new documentation at https://klein--594.org.readthedocs.build/en/594/ — specifically https://klein--594.org.readthedocs.build/en/594/introduction/3-forms.html and https://klein--594.org.readthedocs.build/en/594/introduction/4-auth.html .

It's probably too big to land as-is. In fact, some parts of this are probably entirely new, separate projects that should be a dependency. Some of this stuff might be worth spinning out, but looking at the documentation, it would be difficult to land it piecemeal and get a cohesive story about what it's all for.

@codecov

codecov Bot commented May 18, 2023

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (63516e9) to head (d50ce21).

Additional details and impacted files
@@            Coverage Diff             @@
##             trunk      #594    +/-   ##
==========================================
  Coverage   100.00%   100.00%            
==========================================
  Files           48        63    +15     
  Lines         3981      4857   +876     
  Branches       182       201    +19     
==========================================
+ Hits          3981      4857   +876     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

glyph added 29 commits May 30, 2023 23:28
- move memory session store to its own dedicated package
- implement MemoryAccountStore (i.e. ISimpleAccount/ISimpleAccountBinding authorizers)
at least on pypy3.9, typing.Protocol appears to runtime-check its args to make
sure they are all TypeVars (i.e. not ParamSpecs)
Comment thread src/klein/test/test_plating.py Outdated
Comment thread src/klein/test/test_form.py Outdated
Comment thread src/klein/storage/sql/_sql_dal.py
Comment thread src/klein/storage/sql/_transactions.py

@gkrnours gkrnours left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@glyph

glyph commented Jul 24, 2026

Copy link
Copy Markdown
Member Author

@gkrnours In the course of fixing the deleteSession issue that you raised, I did have to go and add a little more test coverage to the insecure-token-scrubbing logic; specifically, making sure we didn't scrub ALL sessions (including insecure sessions) every time we use an insecure transport. Other than that though, I think this is ready to go!

@glyph
glyph merged commit 9669dbc into trunk Jul 24, 2026
32 of 34 checks passed
@glyph
glyph deleted the lots-more-docs branch July 24, 2026 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants