Fix code review bugs, add 20 edge case tests#12
Merged
twokidsCarl merged 1 commit intomainfrom Apr 8, 2026
Merged
Conversation
Bug fixes from code review: - Fix missing return in handle_smart_input (MVU tuple broken) - Initialize @saved_input to prevent history navigation crash - Add rescue to InputHandler.completions (stale binding safety) - Add rescue to handle_tab_completion (never crash TUI) - Catch SystemExit in eval_ruby (user code calling exit) - Remove unused width param from StatusBar.build_right - Fix /source fallback condition (match all error types, not just "not found") - Wrap baseline_methods init in rescue 20 new tests (85 total): - Smart routing: NameError on single-word, string/array literals, MVU tuple - History: empty history, boundary, saved input preservation - Tab: empty prefix, no matches, slash command completion - /source: REPL-defined method fallback - eval_ruby: SyntaxError/NameError catch, success case - Baseline methods: new method detection - StatusBar: model name, scroll hint - /help: alignment, removed commands, hints Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (7)
Walkthrough此PR改进了TUI的异常处理机制,使eval、补全和源代码查询对异常更具弹性,调整了多个组件的控制流,更新了状态栏方法签名,并扩展了测试覆盖范围,版本号随之更新。 Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Bug fixes
returnon handle_llm callsTest plan
🤖 Generated with Claude Code
Summary by CodeRabbit
发行说明
错误修复
重构
测试