Skip to content

Use forked bubbletea with IME fix#13

Merged
twokidsCarl merged 2 commits intomainfrom
fix/bubbletea-ime-fork
Apr 8, 2026
Merged

Use forked bubbletea with IME fix#13
twokidsCarl merged 2 commits intomainfrom
fix/bubbletea-ime-fork

Conversation

@twokidsCarl
Copy link
Copy Markdown
Owner

@twokidsCarl twokidsCarl commented Apr 8, 2026

Summary

  • Point Gemfile to twokidsCarl/bubbletea-ruby fork (branch fix/ime-multi-byte-input) for CI
  • Use local path ../bubbletea-ruby for development
  • This enables the IME/CJK multi-byte input fix (internal byte buffering in poll_event) until upstream merges marcoroth/bubbletea-ruby#7

Test plan

  • All 85 TUI tests pass
  • Manual: type Chinese "你好" in terminal, verify both characters appear

🤖 Generated with Claude Code

Summary by CodeRabbit

发布说明

  • 杂项
    • 更新构建版本号至最新版本
    • 改进了多字节字符输入处理能力

Points Gemfile to twokidsCarl/bubbletea-ruby fork (branch
fix/ime-multi-byte-input) which adds internal byte buffering in
poll_event to correctly handle CJK/IME multi-byte sequences.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 8, 2026

Warning

Rate limit exceeded

@twokidsCarl has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 18 minutes and 48 seconds before requesting another review.

Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 18 minutes and 48 seconds.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 46f115ee-92d1-4c0b-b693-368809e02fff

📥 Commits

Reviewing files that changed from the base of the PR and between efc43ca and 86da569.

📒 Files selected for processing (2)
  • Gemfile
  • lib/claw/version.rb

Walkthrough

在 Gemfile 中条件性地添加了 bubbletea gem 依赖,在 CI 环境中从 GitHub 仓库的特定分支拉取,非 CI 环境从本地路径引用。同时将版本号从 20260407-008 更新到 20260407-009

Changes

内聚组 / 文件 总结
依赖管理
Gemfile
在 CI 和非 CI 环境中添加 bubbletea gem,分别引用 GitHub 分支 fix/ime-multi-byte-input 和本地路径 ../bubbletea-ruby
版本更新
lib/claw/version.rb
Claw::BUILD 常数从 20260407-008 更新为 20260407-009

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed 拉取请求的标题清晰准确地反映了变更集的主要改动,即引入带有IME修复的分叉bubbletea库。
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/bubbletea-ime-fork

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@Gemfile`:
- Line 7: The Gemfile currently points to the GitHub branch
fix/ime-multi-byte-input (commit f1b64c5d15b38...) for gem "bubbletea", but that
branch declares a native extension (ext/bubbletea/extconf.rb) which causes CI to
fail with Gem::Ext::BuildError; replace the branch reference with a pinned,
known-good commit SHA or a released tag that has been verified to build in CI
(update the gem "bubbletea" entry to use ref: "<verified-commit-sha>"), and add
a brief root-cause note to the PR describing the native-extension build failure
(compilation/environment/dependencies) so we can later investigate the
ext/bubbletea/extconf.rb changes without blocking the merge.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: c8ccd0f0-6e5b-4eb5-b171-394fc22b495e

📥 Commits

Reviewing files that changed from the base of the PR and between b01faf7 and efc43ca.

⛔ Files ignored due to path filters (1)
  • Gemfile.lock is excluded by !**/*.lock
📒 Files selected for processing (2)
  • Gemfile
  • lib/claw/version.rb

Comment thread Gemfile Outdated
CI uses precompiled gem from RubyGems (no Go build needed).
Local dev uses path to ../bubbletea-ruby fork with IME fix.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@twokidsCarl twokidsCarl merged commit aee353e into main Apr 8, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant